Add missing type annotations to core library method signatures#8184
Merged
dereuromark merged 1 commit into5.xfrom Jan 28, 2026
Merged
Add missing type annotations to core library method signatures#8184dereuromark merged 1 commit into5.xfrom
dereuromark merged 1 commit into5.xfrom
Conversation
Updated method signatures to include proper type annotations: - app.md: className() parameter types - collections.md: ~33 methods with full type annotations - email.md: setAttachments(), setEmailPattern() types and return - inflector.md: All 10 methods already had types (verified) - number.md: setDefaultCurrency() static and nullable type - text.md: transliterate(), toList() types (verified) - time.md: setJsonEncodeFormat(), i18nFormat(), comparison methods - xml.md: build(), toArray() types (verified) Refs #7744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files updated:
className()- addedstringtypes for parameterssetAttachments(),setEmailPattern()- added parameter types and return typessetDefaultCurrency()- changed tostaticand added nullable string typetransliterate(),toList()- verified types match sourcebuild(),toArray()- verified types match sourceTest plan
Refs #7744